Skip to content

Comments

feat: deno bundle for typescript#388

Open
dmmordvi wants to merge 2 commits intohelm-v3.14.3-for-werffrom
feat/ts-deno-bundle
Open

feat: deno bundle for typescript#388
dmmordvi wants to merge 2 commits intohelm-v3.14.3-for-werffrom
feat/ts-deno-bundle

Conversation

@dmmordvi
Copy link

@dmmordvi dmmordvi commented Feb 20, 2026 •
edited by bito-code-review bot
Loading

Summary by Bito

This pull request adds TypeScript bundling support to Helm charts using Deno, enabling developers to write chart logic in TypeScript that gets compiled to JavaScript bundles during the chart packaging process, building on existing functionality for processing and bundling TypeScript files recursively across charts and dependencies.

Detailed Changes
  • Renames ProcessChartRecursive to BundleTSChartsRecursive in pkg/werf/ts/bundle.go, adds rebuild logic to remove existing bundles, and includes checks for subchart directory existence to skip bundling for archived or missing charts
  • Modifies GetEntrypointAndBundle in pkg/werf/ts/bundle.go to return a file pointer instead of byte data for better file handling
  • Updates pkg/chart/chart.go to add RemoveRuntimeFile method, modify AddRuntimeFile with a new helper function getRootRawFileName, remove RuntimeDepsFiles field, and relocate hasManifestExtension function
  • Changes file loading logic in pkg/chart/loader/load.go to treat ts/node_modules files as RuntimeFiles instead of RuntimeDepsFiles
  • Updates pkg/action/package.go to invoke the renamed BundleTSChartsRecursive function for TypeScript processing

@dmmordvi
feat: deno bundle for typescript
1c4ba13 
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
@bito-code-review
Copy link

bito-code-review bot commented Feb 20, 2026 •
edited
Loading

Code Review Agent Run #8c965a

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: 1c4ba13..1c4ba13
    • pkg/action/package.go
    • pkg/chart/chart.go
    • pkg/werf/ts/bundle.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Golangci-lint (Linter) - ✖︎ Failed
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at ilya.lesikov@flant.com.

Documentation & Help

AI Code Review powered by Bito Logo

@dmmordvi
feat: skip for tgz
5d04719 
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
@bito-code-review
Copy link

bito-code-review bot commented Feb 20, 2026 •
edited
Loading

Code Review Agent Run #5b3faa

Actionable Suggestions - 0
Review Details
  • Files reviewed - 4 · Commit Range: 1c4ba13..5d04719
    • pkg/action/package.go
    • pkg/chart/chart.go
    • pkg/chart/loader/load.go
    • pkg/werf/ts/bundle.go
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Golangci-lint (Linter) - ✖︎ Failed
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at ilya.lesikov@flant.com.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilya-lesikov ilya-lesikov Awaiting requested review from ilya-lesikov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dmmordvi